Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAPPS-DB] Convert more zip packages to zip installers #297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[RAPPS-DB] Convert more zip packages to zip installers #297

wants to merge 1 commit into from

Conversation

whindsaks
Copy link
Contributor

Notes:

  • ccleste, cstalin, fall, maelstorm and xrick rely on the recently added Rapps shortcut working directory enhancement to run correctly.
  • CStalin defaults to Spanish but that is a flaw in their .zip distribution and not something this PR can fix.
  • Neverball should probably be converted at some point but I could not get it to run in my VM.
  • Openarena should probably be converted at some point but it's so large, I did not test it.

@whindsaks whindsaks added the enhancement New feature or request label Jan 30, 2025
HBelusca
HBelusca approved these changes Feb 3, 2025
View reviewed changes
hiawatha.txt
DelFile = work\hiawatha.pid
DelDir = logfiles
DelDirEmpty = work\upload|work
DelRegEmpty = HKCU\Software\Cygwin\Program Options|HKCU\Software\Cygwin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work fine in case there exists other Cygwin-based programs (incl. Cygwin itself) on the system?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes because it only deletes if the key is empty (hiawatha does not seem to write anything there)

julenuri
julenuri approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@julenuri julenuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending of testing this under ReactOS to see if the behavior is the expected.

@whindsaks
Copy link
Contributor Author

Pending of testing this under ReactOS to see if the behavior is the expected.

I personally tested every installer changed here but of course mistakes and oversights can happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HBelusca HBelusca HBelusca approved these changes

@julenuri julenuri julenuri approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whindsaks @HBelusca @julenuri